[PATCH] D33372: Infer relocation model from module flags in relocatable LTO link

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 20 04:13:16 PDT 2017


joerg added a comment.

In https://reviews.llvm.org/D33372#760060, @pcc wrote:

> > Non-LTO pipeline allows the user to put PIC code in a non-PIE executable, or non-PIC code in a shared library if they wish so. Maybe we should completely ignore the output type here and strictly go by module flags, to be consistent.
>
> Disabling PIC can sometimes act as an optimization.


Disabling PIC was a performance hack on 32bit x86 due to the extreme register starvation of the architecture.
It is also generally agreed that it is fundamentally broken from a design perspective. I don't see good reasons for supporting that, frankly.


Repository:
  rL LLVM

https://reviews.llvm.org/D33372





More information about the llvm-commits mailing list