[PATCH] D33355: [IR] Add additional addParamAttr/removeParamAttr to AttributeList API

[Javed Absar via Phabricator via llvm-commits]

javed.absar added a comment.

Thanks a lot for this. Some small comments -



================
Comment at: include/llvm/IR/Attributes.h:418
+  /// Add an attribute to the attribute set at the given arg indices. Because
+  /// attribute sets are immutable, this returns a new set.
+  AttributeList addParamAttribute(LLVMContext &C, ArrayRef<unsigned> ArgNos,
----------------
1. "returns a new set" => "returns a new list".

2. Nitpick - it would be nice to make all such sentences same, some places we seem to start with "Returns a .. because.." other places as "Because.... returns..."


================
Comment at: include/llvm/IR/Attributes.h:591
 
+  /// \brief Return the attribute object that exists at the arg index.
+  Attribute getParamAttr(unsigned ArgNo, Attribute::AttrKind Kind) const {
----------------
Should this comment be "exists at the arg number"?


https://reviews.llvm.org/D33355