[PATCH] D33180: Add functionality to cvtres to parse all entries in res file.

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 19 15:57:46 PDT 2017


ecbeckmann added inline comments.


================
Comment at: llvm/tools/llvm-cvtres/llvm-cvtres.h:15
+
+void error(std::error_code EC);
+
----------------
ruiu wrote:
> ecbeckmann wrote:
> > zturner wrote:
> > > Can you put this in the same file as the other enum?  That said, it looks like maybe it is only used from 1 file?  In that case make it static inline in the file where you need it.
> > In future patches this function will surely be used in multiple files.
> Add this header in the future patch which needs this header. Adding a stub is usually fine, but this file seems too stub-y.
The header file itself is has already been  commited into LLVM...are you saying we should not put the declarations here yet?


https://reviews.llvm.org/D33180





More information about the llvm-commits mailing list