[PATCH] D33059: Create an shared include directory for gtest helper functions

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D33059#758161, @zturner wrote:

> Moved the folder.


I don't particularly like the new name. ;]

Because we're not going to install anything, I don't think we need the 'include' directory component or to separate the headers from the source files.

If your concern is that `#include "Helpers/Foo.h"` isn't clear because `Helpers` is too generic, how about `TestHelpers` or `UnittestHelpers`? I'd still keep a single directory, and use more typical LLVM NamingConvention for it. =]

> I really would like to put it in `utils\unittest\googletest\include\gtest\Support`, because then you could write
> 
>   #include "gtest/gtest.h"
>   #include "gtest/Support/ErrorChecking.h"

Yeah this would be nice, but...

> but I'm not sure if sticking our own directory inside of a directory of third party code would be weird.

I also think i would be weird. I'd like us to keep it separate.


https://reviews.llvm.org/D33059