[PATCH] D33158: [compiler-rt] Replace ifs with switch statement in IsHandledDeadlySignal

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 16:20:14 PDT 2017


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:397
 bool IsHandledDeadlySignal(int signum) {
-  if ((SANITIZER_WATCHOS || SANITIZER_TVOS) && !(SANITIZER_IOSSIM))
+  if ((SANITIZER_WATCHOS || SANITIZER_TVOS) && !(SANITIZER_IOSSIM)) {
     // Handling fatal signals on watchOS and tvOS devices is disallowed.
----------------
I think we normally don't do braces on single-line if statements. I'd move the comment one line up though.


https://reviews.llvm.org/D33158





More information about the llvm-commits mailing list