[PATCH] D33327: Use linker script commands in writeMapFile

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 12:09:53 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/Writer.cpp:294
> +  // commands.
> +  OutputSections.clear();
> +
> ----------------
> The only thing we have below is writeMapFile, so it's probably too late to do this. I'd move this up or remove.

The idea is to gradually move it up. In this patch I convert
writeMapFile and put the clear just before it. In followup patches I
will incrementally move it further up.

Cheers,
Rafael


More information about the llvm-commits mailing list