[PATCH] D33330: COFF: Replace DLLNames maps with vectors.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 12:01:40 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/DLL.cpp:429
+    DLLNames.push_back(make<StringChunk>(Syms[0]->getDLLName()));
+    auto Dir = make<ImportDirectoryChunk>(DLLNames.back());
     Dir->LookupTab = Lookups[Base];
----------------
auto *


================
Comment at: lld/COFF/DLL.cpp:466
+    DLLNames.push_back(make<StringChunk>(Syms[0]->getDLLName()));
+    auto Dir = make<DelayDirectoryChunk>(DLLNames.back());
 
----------------
auto *


https://reviews.llvm.org/D33330





More information about the llvm-commits mailing list