[PATCH] D33326: Merge IAT and ILT.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 11:26:12 PDT 2017


pcc added a comment.

Please add a comment somewhere explaining why we can merge them.



================
Comment at: lld/COFF/DLL.cpp:430
     auto *Dir = make<ImportDirectoryChunk>(DLLNames[Name]);
-    Dir->LookupTab = Lookups[Base];
+    Dir->LookupTab = Addresses[Base];
     Dir->AddressTab = Addresses[Base];
----------------
I think you could simplify this further by removing the LookupTab field.


https://reviews.llvm.org/D33326





More information about the llvm-commits mailing list