[PATCH] D32252: [GVN] Add phi-translate for scalarpre as a temporary solution

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 09:51:51 PDT 2017


dberlin added a comment.

Pretty good at this point.
I don't understand why you changed the CHECK-NEXT lines to CHECK lines though.
Can you explain?



================
Comment at: lib/Transforms/Scalar/GVN.cpp:239
   e.opcode = I->getOpcode();
+  e.commutative = false;
   for (Instruction::op_iterator OI = I->op_begin(), OE = I->op_end();
----------------
Just initialize it to false in the constructor


Repository:
  rL LLVM

https://reviews.llvm.org/D32252





More information about the llvm-commits mailing list