[PATCH] D33112: Optimize orphan plament in a general way

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu May 18 09:34:01 PDT 2017


Andrew Ng via Phabricator <reviews at reviews.llvm.org> writes:

> andrewng added inline comments.
>
>
> ================
> Comment at: ELF/Writer.cpp:645
> +  RF_MIPS_GPREL = 1 << 2,
> +  RF_MIPS_NOT_GOT = 1 << 1
> +};
> ----------------
> Is there a reason why this starts with 1 and not 0? i.e. 1 << 0

No, just fixed it.

Thanks,
Rafael


More information about the llvm-commits mailing list