[PATCH] D33287: [Linker] Add support for linking ARM and Thumb IR modules.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

@echristo I've created a separate review to remove the Thumb target machines (https://reviews.llvm.org/D33318)

Are there any cases in particular you are worried about when it comes to Thumb/ARM code generation in the same compilation unit? I was thinking about compiling and running a big set of tests with a version of clang that randomly adds +thumb-mode to some functions. This should help increasing the confidence in mixing Thumb/ARM code generation in the same compilation unit.

@tejohnson as far as I am aware of, one (probably minor) drawback of doing it in clang would be that other frontends might also need to add +-thumb-mode in case they want to link ARM and Thumb modules. Also, when it comes to the warning about incompatible triples from the linker, we would have to trust clang to add the +thumb-mode feature in order to silence the message for armxx and thumbxx triples.


https://reviews.llvm.org/D33287