[PATCH] D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

Hello Guys,

To make a progress with landing this patch I need a feedback from you. As I see:

1. Chandler had no issues with this patch
2. David in his e-mail wrote that he is ok with this patch
3. Duncan made a proposal to dd some tests with switch.

There are several tests currently with switch statement with unreachable involved:
basic.ll:@test_unreachable_with_switch_prof1
basic.ll:@test_unreachable_with_switch_prof2
basic.ll:@test_unreachable_with_switch_prof3
basic.ll:@test_unreachable_with_switch_prof4
noreturn.ll:@test2
some of them shows that sum of probabilities are not equal to one:
basic.ll:@test_unreachable_with_switch_prof4

Do you want to see some specific tests to be added?

Is there any thing else what prevent you from accepting this change? Please let me know and I'll fix it.


https://reviews.llvm.org/D30633