[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 17:23:57 PDT 2017


probinson added a comment.

>   I'd probably/ideally have staged the work to separate the needed properties out of the CU abstractions first,

Yeah, well, I didn't come to terms with that direction until I was really pretty invested in this piece.  But hey, if I knew what the endpoint was up front, it wouldn't be iterative development.
Sadly, what has struck me just this minute (after posting the diff of course) is that what's currently the nested FormValueInfo class is probably going to have to be factored out on its own so callers can DTRT and then hand over a constructed helper to DWARFFormValue.  Oh well.


https://reviews.llvm.org/D33155





More information about the llvm-commits mailing list