[PATCH] D33059: Create an shared include directory for gtest helper functions

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 16:57:31 PDT 2017


chandlerc added a comment.

I definitely want this. First question is where?

I don't think this should be under `include/llvm` because it isn't a public header of LLVM. Nothing in `lib/...` should use it, etc.

How about `utils/unittest/Helpers/Foo.h`? We can even add `.../Foo.cpp` if/when we need it? Then we can just make these headers available similarly to how we make the google test headers available.


https://reviews.llvm.org/D33059





More information about the llvm-commits mailing list