[PATCH] D33300: [ImplicitNullChecks] Uphold an invariant in areMemoryOpsAliased

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 15:23:48 PDT 2017


sanjoy added inline comments.


================
Comment at: lib/CodeGen/ImplicitNullChecks.cpp:375
   for (auto *PrevMI : PrevInsts)
     for (auto &PrevMO : PrevMI->operands()) {
       // Check whether the current memory access aliases with previous one.
----------------
I also noticed that there was no need to loop over `PrevMI->operands()` for the second clause here (`if (Suitable == SR_Suitable)` ...).  I'll remove that control flow in a next patch which should be NFC.


https://reviews.llvm.org/D33300





More information about the llvm-commits mailing list