[PATCH] D33237: [GSoC] Shell autocompletion for clang

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I'm fine with these nits. (Am I supposed to sign off?)



================
Comment at: clang/test/Driver/autocomplete.c:4
+// RUN: %clang --autocomplete=-s | FileCheck %s -check-prefix=STD
+// STD: -std= -stdlib=
+// RUN: %clang --autocomplete=foo | not FileCheck %s -check-prefix=NONE
----------------
You want to change this to `-std={{.*}}-stdlib=` to make robust for changes that add new options which are between the top in the asciibetical order.


================
Comment at: clang/test/Driver/autocomplete.c:6
+// RUN: %clang --autocomplete=foo | not FileCheck %s -check-prefix=NONE
+// NONE: {{%[a-z]}}
----------------
Maybe just `foo` suffices. `%` doesn't seem make sense to me.


================
Comment at: clang/utils/bash-autocomplete.sh:14
+} 
+    complete -F _clang clang
----------------
Fix indentation.


https://reviews.llvm.org/D33237