[PATCH] D33151: ThinLTO: Verify bitcode before lauching the ThinLTOCodeGenerator.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 09:39:56 PDT 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D33151#757534, @aprantl wrote:

> In https://reviews.llvm.org/D33151#756851, @aprantl wrote:
>
> > In https://reviews.llvm.org/D33151#756801, @mehdi_amini wrote:
> >
> > > It is likely before `run()` was improved to be able to handle `CodeGenOnly`, we should retarget llvm-lto to use `run()` instead. I can do this if you want (likely tonight or tomorrow night)
> >
>
>
> Thanks for the offer! Please let me know if you won't get to it. If you can just quickly sketch what needs to be done I can do the grunt work, too.


It should be fairly straightforward, just mimicking the C API: it should be only replacing the call to `codegen()` with two calls to `setCodeGenOnly(true)` and then `run()` (that's the best case, but I haven't looked yet, the code may not be setup to do it so easily).


https://reviews.llvm.org/D33151





More information about the llvm-commits mailing list