[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Oren Ben Simhon via Phabricator via llvm-commits]

oren_ben_simhon marked 5 inline comments as done.
oren_ben_simhon added a comment.

In https://reviews.llvm.org/D33169#755488, @RKSimon wrote:

> A possible addition would be to custom lower i8/i16 vectors with a trunc(popcnt(zext))) pattern.


I agree with you, Will it be OK to create a separate patch for it?

In https://reviews.llvm.org/D33169#754377, @RKSimon wrote:

> Disassembler tests?


Thanks for catching that, I added disassembly tests to avx-512.txt



================
Comment at: test/CodeGen/X86/avx512vpopcntdq-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s
+
----------------
craig.topper wrote:
> craig.topper wrote:
> > RKSimon wrote:
> > > Add  --show-mc-encoding ?
> > But should we even have this test file or just use the the popcount tests since these aren't x86 specific intrinsics anymore?
> Nevermind I guess we need this for mask testing? I assume the generic test doesn't cover it.
I moved the tests to corresponding vector_popcnt_*.ll files.
Also the tests check for X86 instructions as such should reside in X86 directory, 


================
Comment at: test/CodeGen/X86/avx512vpopcntdq-intrinsics.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=x86_64-apple-darwin -mattr=+avx512vpopcntdq | FileCheck %s
+
----------------
oren_ben_simhon wrote:
> craig.topper wrote:
> > craig.topper wrote:
> > > RKSimon wrote:
> > > > Add  --show-mc-encoding ?
> > > But should we even have this test file or just use the the popcount tests since these aren't x86 specific intrinsics anymore?
> > Nevermind I guess we need this for mask testing? I assume the generic test doesn't cover it.
> I moved the tests to corresponding vector_popcnt_*.ll files.
> Also the tests check for X86 instructions as such should reside in X86 directory, 
> Add --show-mc-encoding ?
Encoding is not tested in this file. See file test/MC/X86/x86-64-avx512vpopcntdq.s.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169