[PATCH] D33224: [GISel]: Fix more Undefined behavior in GlobalISel::IRTranslator

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 17 02:55:01 PDT 2017


dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:1132-1134
+  /// MachineIRBuilder::DebugLoc can outlive the DILocation it holds. Clear it
+  /// to avoid accessing free’d memory (in runOnMachineFunction) and to avoid
+  /// destroying it twice (in ~IRTranslator() and ~LLVMContext())
----------------
One tiny nit: Doxygen comments don't do anything here as far as I know so these should use `//`


https://reviews.llvm.org/D33224





More information about the llvm-commits mailing list