[PATCH] D33265: [PredicateInfo ] Fix non-determinism in codegen uncovered by reverse iterating SmallPtrSet

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

Actually, please don't land this.
This actually significantly slows down predicateinfo on large files.
The generated differences don't actually matter, either.

If you want to make a SmallPtrSetVector, i'd be more willing to do this, otherwise, i'll just convert the relevant parts.

(FWIW, i think running around the compiler and converting things from SmallPtrSet to to setvector is generally going to be a bad plan, and i'd be pretty opposed. We use SmallPtrSet because it's small and fast.  SetVector is neither of these things)


https://reviews.llvm.org/D33265