[PATCH] D33151: ThinLTO: Verify bitcode before lauching the ThinLTOCodeGenerator.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 13:49:40 PDT 2017


aprantl marked 2 inline comments as done.
aprantl added inline comments.


================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:470
+  // Verify again to catch all cross-imports.
+  verifyMergedModule(TheModule);
   optimizeModule(TheModule, TM, OptLevel, Freestanding);
----------------
mehdi_amini wrote:
> How costly is it to do it two times?
> I guess there is not much choice any way with respect to debug info....
> 
> Do we have testing for this?
The verifier is not terribly expensive, but it does visit every entity in the module once.


https://reviews.llvm.org/D33151





More information about the llvm-commits mailing list