[PATCH] D33145: Clear output section from linker script command when it's removed.

Dmitry Mikulin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 11:26:41 PDT 2017


dmikulin added inline comments.


================
Comment at: ELF/LinkerScript.cpp:703
 
-    auto *OutSec = make<OutputSection>(Cmd->Name, Type, Flags);
+    auto *OutSec = make<OutputSection>(Cmd->Name, SHT_PROGBITS, Flags);
     OutSec->SectionIndex = I;
----------------
ruiu wrote:
> What is the meaning of this change?
Rafael suggested that we should not be tracking section types of previous sections and always use PROGBITS for dummy sections.


https://reviews.llvm.org/D33145





More information about the llvm-commits mailing list