[PATCH] D33216: Generate ubsan shared libraries.

[Leo Li via Phabricator via llvm-commits]

aoli added inline comments.


================
Comment at: lib/ubsan/CMakeLists.txt:170
+      PARENT_TARGET ubsan)
+
     if (UNIX)
----------------
vsk wrote:
> I'm not familiar with the differences between RTUbsan_cxx and its C variant, but for consistency with what's already here, should we have 'SHARED' versions of clang_rt.ubsan_standalone and clang_rt.ubsan_standalone_cxx?
> 
> Also: do you know whether the ubsan standalone runtimes are tested in a `check-ubsan` test run?
I've updated the CMakeList.txt which generates both clang_rt.ubsan_standalone and clang_rt.ubsan_standalone_cxx now. It seems that the ubsan standalone runtimes are tested in the test run. https://github.com/llvm-mirror/compiler-rt/blob/master/test/ubsan/CMakeLists.txt#L26 


https://reviews.llvm.org/D33216