[PATCH] D33157: [Inliner] Do not mix callsite and callee hotness based updates.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 11:02:04 PDT 2017


chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

(Just marking this as no longer ready to go so it shows back up in my queue...)

In https://reviews.llvm.org/D33157#756345, @eraman wrote:

> Turns out that this change is incorrect.  When sample profile is used, we use callsite hotness even without BFI. In a separate patch, I plan to add a method in ProfileSummaryInfo to determine if the module has sample profile. Then I can fix this patch by using callsite hotness either when sample profile is used or when BFI is available.


Good catch!!!


https://reviews.llvm.org/D33157





More information about the llvm-commits mailing list