[PATCH] D30633: [BPI] Reduce the probability of unreachable edge to minimal value greater than 0

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 10:18:27 PDT 2017


skatkov added a comment.

Chandler is right in all comments :)

1. The main motivation of the patch is to avoid "the case where the UR branch probability ends up *higher* than the loop exit branch probability". In this terms I'm completely ok with this patch and there is not need to go with zero. The question about zero from my side was mostly about understanding why zero is not good.
2. Th UR branch probability without patch is equal to 1/(2^20) while with this change it will be 1/(2^31), so with the patch it becomes lower.


https://reviews.llvm.org/D30633





More information about the llvm-commits mailing list