[PATCH] D33198: Header file to help forcibly link GPURuntime

Singapuram Sanjay Srivallabh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 16 06:40:21 PDT 2017


singam-sanjay marked an inline comment as done.
singam-sanjay added inline comments.


================
Comment at: include/polly/Support/LinkGPURuntime.h:34
+    polly_initContextCUDA();
+    polly_getKernel(nullptr, nullptr);
+    polly_freeKernel((PollyGPUFunction*)nullptr);
----------------
singam-sanjay wrote:
> Should I typecast the nullptr (like in the line below) or leave it as is ?
I've removed all pointer and integer type casts.


================
Comment at: include/polly/Support/LinkGPURuntime.h:43
+    }
+  } structure;
+}
----------------
I'm now using a static structure variable instead a function call to force-link, like LinkAllIR.h. This change would make it simpler to force-link by only requiring a #include line for LinkGPURuntime.h .


Repository:
  rL LLVM

https://reviews.llvm.org/D33198





More information about the llvm-commits mailing list