[PATCH] D33121: [SCEV] Fix sorting order for AddRecExprs

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 22:24:07 PDT 2017


sanjoy added a comment.

I have two more comments:

- Can you also add an assert in `getAddExpr` checking that the expressions are sorted like we expected?
- Can you please add a comment in `CompareSCEVComplexity` on why the ordering is needed?  A one-liner that "we need this in getAddExpr" is sufficient.


https://reviews.llvm.org/D33121





More information about the llvm-commits mailing list