[llvm] r303133 - [InstCombine] add tests for PR32791; NFC

[Davide Italiano via llvm-commits]

On Mon, May 15, 2017 at 6:35 PM, Sanjay Patel <spatel at rotateright.com> wrote:
> This isn't "code"; it's test coverage. In any case, I won't be able revert
> this myself until tomorrow morning (mountain time zone). Since you obviously
> object to this commit, can you revert it for me?
>
> note that in addition to a potential transform, these tests add coverage for
> a potential infinite loop from conflicting InstCombines. Having encountered
> more than my fair share of those, I'd like to see far more of these negative
> regression tests, so I hit them during development rather than via bug
> report.
>

There's no rush reverting this, as it's not breaking things.
I'm fine with leaving the tests for the infinite loop, but please add
a comment explaining that.
I'd appreciate if we can continue the discussion on whether this
transformation should live on phabricator before we go forward with
this.

--
Davide