[PATCH] D33121: [SCEV] Fix sorting order for AddRecExprs

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 18:05:43 PDT 2017


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with one comment.



================
Comment at: lib/Analysis/ScalarEvolution.cpp:638
+      assert(LHead != RHead && "Two loops share the same header?");
+      if (DT.dominates(LHead, RHead))
+        return 1;
----------------
Can we assert `DT.dominates(LHead, RHead) || DT.dominates(RHead, LHead)` here?


https://reviews.llvm.org/D33121





More information about the llvm-commits mailing list