[PATCH] D33217: [libunwind] Fix a check from __GNU__ to __GNUC__ for disabling executable stack.

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 16:15:30 PDT 2017


manojgupta updated this revision to Diff 99081.
manojgupta added a comment.

Removed redundant check for Android since __linux__ should cover it.


https://reviews.llvm.org/D33217

Files:
  src/assembly.h


Index: src/assembly.h
===================================================================
--- src/assembly.h
+++ src/assembly.h
@@ -47,8 +47,8 @@
 #define SYMBOL_IS_FUNC(name) .type name, at function
 #endif
 
-#if defined(__GNU__) || defined(__ANDROID__) || defined(__FreeBSD__) || \
-    defined(__Fuchsia__)
+#if defined(__GNU__) || defined(__FreeBSD__) || defined(__Fuchsia__) || \
+    defined(__linux__)
 #define NO_EXEC_STACK_DIRECTIVE .section .note.GNU-stack,"",%progbits
 #else
 #define NO_EXEC_STACK_DIRECTIVE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33217.99081.patch
Type: text/x-patch
Size: 518 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170515/cf55ba60/attachment.bin>


More information about the llvm-commits mailing list