[PATCH] D32605: Recognize CTLZ builtin

Evgeny Stupachenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 13:21:05 PDT 2017


evstupac added a comment.

In https://reviews.llvm.org/D32605#755422, @joerg wrote:

> In https://reviews.llvm.org/D32605#755237, @evstupac wrote:
>
> > In https://reviews.llvm.org/D32605#755223, @joerg wrote:
> >
> > > Can you check the countable part in one of the cases? Otherwise it looks good.
> >
> >
> > If I get yuo right, "ctlz_and_other" checks conversion to countable loop and that CPUs that not support ctlz will not insert it in this case.
>
>
> I mean: it doesn't translate the loop to use ctlz, but the comment suggests that it still transforms the loop into something better understood. But it doesn't test that part?


Get it.
Yes you are right, it would be good to check that loop exit condition was changed as well.
I'll update the test accordingly.


Repository:
  rL LLVM

https://reviews.llvm.org/D32605





More information about the llvm-commits mailing list