[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

Oren Ben Simhon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 12:44:54 PDT 2017


oren_ben_simhon added a comment.

Please notice that clang-format reformatted some lists that I modified in the file lib/Target/X86/X86InstrInfo.cpp.
It caused major cosmetic changes which introduce many diffs in that file.

In https://reviews.llvm.org/D33169#754377, @RKSimon wrote:

> Disassembler tests?


I believe that the test test/MC/X86/x86-64-avx512vpopcntdq.s covers the required tests. 
If you think additional tests are required i will appreciate an example.

In https://reviews.llvm.org/D33169#754316, @RKSimon wrote:

> Add cost-model support in X86TTIImpl::getIntrinsicInstrCost


Since AVX512 is missing from the cost table and since i need some investigation on this subject, I prefer to make this changes in different patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169





More information about the llvm-commits mailing list