[PATCH] D33202: [LTO] Use GlobalValue::getComdat which knows how to handle ifuncs

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson updated this revision to Diff 99029.
tejohnson added a comment.

Update per review


https://reviews.llvm.org/D33202

Files:
  lib/IR/Globals.cpp
  test/LTO/Resolution/X86/ifunc.ll
  test/Object/X86/nm-ir.ll


Index: test/Object/X86/nm-ir.ll
===================================================================
--- test/Object/X86/nm-ir.ll
+++ test/Object/X86/nm-ir.ll
@@ -12,7 +12,7 @@
 ; CHECK-NEXT: C g3
 ; CHECK-NOT: g4
 ; CHECK-NEXT: T global_asm_sym
-; CHECK-NEXT: D ifunc_f1
+; CHECK-NEXT: T ifunc_f1
 ; CHECK-NEXT: t local_asm_sym
 ; CHECK-NEXT: U undef_asm_sy
 
Index: test/LTO/Resolution/X86/ifunc.ll
===================================================================
--- /dev/null
+++ test/LTO/Resolution/X86/ifunc.ll
@@ -0,0 +1,15 @@
+; RUN: opt -module-summary -o %t.bc %s
+; RUN: llvm-lto2 run %t.bc -r %t.bc,foo,pl -o %t2
+; RUN: llvm-nm %t2.0 | FileCheck %s
+; CHECK: T foo
+; CHECK: t foo_ifunc
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+ at foo = ifunc i32 (i32), i64 ()* @foo_ifunc
+
+define internal i64 @foo_ifunc() {
+entry:
+  ret i64 0
+}
Index: lib/IR/Globals.cpp
===================================================================
--- lib/IR/Globals.cpp
+++ lib/IR/Globals.cpp
@@ -255,7 +255,7 @@
 const GlobalObject *GlobalValue::getBaseObject() const {
   if (auto *GO = dyn_cast<GlobalObject>(this))
     return GO;
-  if (auto *GA = dyn_cast<GlobalAlias>(this))
+  if (auto *GA = dyn_cast<GlobalIndirectSymbol>(this))
     return GA->getBaseObject();
   return nullptr;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33202.99029.patch
Type: text/x-patch
Size: 1357 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170515/a2025046/attachment.bin>