[PATCH] D33176: ELF: --gdb-index: Change findSection to return an InputSection.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D33176#754713, @grimar wrote:

> So findSection() approach does not seem to be clean itself and that is root of problem it seems. 
>  We probably can land this one to stop crashing (and as a bonus it adds testcase which also seems useful to have),
>  but for solving general issue I just posted https://reviews.llvm.org/D33183 which removes findSection() need and not only 
>  speedup things but also should fix issue this patch addresses either.


Agreed that we should fix the interface (thanks for working on that!), and that this is useful at least for the test case.

In https://reviews.llvm.org/D33176#755234, @ruiu wrote:

> How did you create that object file? At least you want to leave a comment in the test about how you created it.


See lld/test/ELF/Inputs/gdb-index-empty.o.sh, but I'll convert this to a .s.


https://reviews.llvm.org/D33176