[PATCH] D33184: [DWARF] - Make collectAddressRanges() return section index in addition to Low/High PC

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 10:14:05 PDT 2017


dblaikie added a comment.

+1 to Rafael



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugRangeList.h:25-27
+struct DWARFAddress {
+  uint64_t LowPC;
+  uint64_t HighPC;
----------------
This should probably be called DWARFAddressRange since it represents more than a single address (or possibly no addresses, if the range is empty) - and I think that's the right terminology in DWARF (that a contiguous range is a 'range' and a series of ranges is a 'range list').


https://reviews.llvm.org/D33184





More information about the llvm-commits mailing list