[PATCH] D33144: [RegisterBankInfo] Remove overly-agressive asserts

[Tom Stellard via Phabricator via llvm-commits]

tstellar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/RegBankSelect.cpp:449
     uint64_t RepairCost = getRepairCost(MO, ValMapping);
     // Bias used for splitting: 5%.
     const uint64_t PercentageForBias = 5;
----------------
qcolombet wrote:
> Add a check for the RepairCost here. Otherwise we are going to have overflow in the following computation.
> 
> I.e., if (RepairCost == UINT_MAX)
>             continue;
Hi Quentin,

I committed with continue;  but after running some more tests, shouldn't it really be:


if (RepairCost == UINT_MAX)
  return MappingCost::ImpossibleCost();


Repository:
  rL LLVM

https://reviews.llvm.org/D33144