[PATCH] D33194: [DWARF] - Cleanup relocations proccessing.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 06:27:38 PDT 2017


grimar created this revision.

There was 3 visible problem this patch trying to fix:

1. RelocAddrMap was defined at 2 difference files at once. I moved definition to DWARFRelocMap.h.
2. RelocAddrMap was a pair of <width, address>, where width is relocation size (4/8), and width field was never used in code.
3. Relocations proccessing loop had checks for width field. I don't think DWARF parser should do that. There is probably no much sense to validate relocations during proccessing them in parser.

Patch moves definition to single file, stops storing width field, stops doing additional checks during handling
of relocations, that all together simplifies the code.


https://reviews.llvm.org/D33194

Files:
  include/llvm/DebugInfo/DWARF/DWARFContext.h
  include/llvm/DebugInfo/DWARF/DWARFRelocMap.h
  lib/DebugInfo/DWARF/DWARFContext.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33194.98995.patch
Type: text/x-patch
Size: 4900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170515/8966fae3/attachment.bin>


More information about the llvm-commits mailing list