[PATCH] D32680: [X86] Apply the new instruction's register classes constraints on the operands of the replaced instruction when memory folding

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 04:10:31 PDT 2017


RKSimon added a comment.

In https://reviews.llvm.org/D32680#744574, @aymanmus wrote:

> @craig.topper, i encountered this issue by coincidence but could not find a test case which fails without this. all the folded instructions right now have the same register classes constrains for both register and memory forms.
>  But as we entirely replace the instruction I saw that this change should be added even though it doesn't effect anything right now. Maybe it will be needed in the future.


Will test cases appear after https://reviews.llvm.org/D32684 is applied?


https://reviews.llvm.org/D32680





More information about the llvm-commits mailing list