[PATCH] D33176: ELF: --gdb-index: Change findSection to return an InputSection.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 03:16:21 PDT 2017


grimar added a comment.

So findSection() approach does not seem to be clean itself and that is root of problem it seems. 
We probably can land this one to stop crashing (and as a bonus it adds testcase which also seems useful to have),
but for solving general issue I just posted https://reviews.llvm.org/D33183 which removes findSection() need and not only 
speedup things but also should fix issue this patch addresses either.

I am OK to land this for start too. Rui ?


https://reviews.llvm.org/D33176





More information about the llvm-commits mailing list