[PATCH] D33044: [NewGVN] Fix verification of MemoryPhis in verifyMemoryCongruency()

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

It's definitely going to be the case that verifyMemoryCongruency is going to have false positives. It can't ever be 100% correct without it being an alternative value numbering method that is provably correct and as complete as our current one :)

Thus, it's limited to doing checks on "likely to be wrong" cases.

So i'm fine with improving it, but we're going to have to disable large parts of it at some point as our value numbering becomes more powerful.
(because we will always be better at finding congruences that it can't be convinced are correct :P)


https://reviews.llvm.org/D33044