[PATCH] D33166: [ValueTracking] Replace all uses of ComputeSignBit with computeKnownBits.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 19:44:14 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineInternal.h:496
                         unsigned Depth, Instruction *CxtI) const {
     return llvm::computeKnownBits(V, Known, DL, Depth, &AC, CxtI, &DT);
   }
----------------
RKSimon wrote:
> Why on earth are we returning a void here?
Fixed in a pre-commit. r303028


https://reviews.llvm.org/D33166





More information about the llvm-commits mailing list