[PATCH] D32712: [ConstantRange] Reduce the number of allocations in ConstantRange::makeGuaranteedNoWrapRegion

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 15:05:57 PDT 2017


sanjoy added a comment.

Hi Craig,

I think this change makes `makeGuaranteedNoWrapRegion` less readable.  Did you take a look at implementing a `ConstantRange::subsetIntersectWith` directly?  That'll be more work, but I think the end result will be cleaner.


https://reviews.llvm.org/D32712





More information about the llvm-commits mailing list