[PATCH] D32614: [GVNHoist] Fix: PR32821, add check for anticipability in case of infinite loops

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 14:07:20 PDT 2017


sanjoy added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GVNHoist.cpp:325
+      const BasicBlock *BB = Queue.back();
+      Queue.pop_back();
+      if (WL.count(BB))
----------------
This is a shallow drive by comment, but do you have to worry about function calls that throw / infloop here?


https://reviews.llvm.org/D32614





More information about the llvm-commits mailing list