[PATCH] D33172: [InstCombine] Simpify inverted predicates in 'or'

Michael Ilseman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 10:58:10 PDT 2017


milseman added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:2288
+  }
+
   return Changed ? &I : nullptr;
----------------
You should probably follow the style of the surrounding code by using the pattern matchers. See PatternMatch.h, and an example at e.g. lines 2261 above.


https://reviews.llvm.org/D33172





More information about the llvm-commits mailing list