[PATCH] D33169: [X86] Adding vpopcntd and vpopcntq instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:7017
   case X86::POPCNT64rr:case X86::POPCNT64rm:
+  case X86::VPOPCNTDZrrk:  case X86::VPOPCNTDZrmk:
+  case X86::VPOPCNTQZrrk:  case X86::VPOPCNTQZrmk:
----------------
I don't think belongs here. These instructions are ones that update EFLAGS Z flag based on their output being 0. That's not ture of VPOPCNTD/Q.


================
Comment at: lib/Target/X86/X86InstrInfo.td:812
+                   AssemblerPredicate<"FeatureVPOPCNTDQ", "AVX-512 VPOPCNTDQ ISA">;
+def NoVPOPCNTDQ : Predicate<"!Subtarget->hasVPOPCNTDQ()">;
 def HasPFI       : Predicate<"Subtarget->hasPFI()">,
----------------
I don't see NoVPOPCNTDQ being used anywhere so we probably shouldn't add it.


Repository:
  rL LLVM

https://reviews.llvm.org/D33169