[PATCH] D29892: ar: add llvm-dlltool support

Martell Malone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 06:30:02 PDT 2017


martell added a comment.

I only updated this for my sanity of having it inline with the other patch.
I should have noted it is not ready for review. Sorry @ruiu.
I think I should wait for @pcc to move the lib driver before updating this again



================
Comment at: lib/CMakeLists.txt:24
 add_subdirectory(Passes)
+add_subdirectory(DlltoolDriver)
 add_subdirectory(LibDriver)
----------------
pcc wrote:
> Just a comment on the location: I'm not sure if we want too many of these tool drivers to live in their own top-level directories under `lib`. If we're planning to add this one and maybe others (cvtres?) we should think about creating a new top-level directory and moving the drivers underneath that directory. My preferred bikeshed colour is: `lib/ToolDrivers/llvm-lib`,  `lib/ToolDrivers/llvm-dlltool`, etc.
> 
> If this sounds good I'll go ahead and move `LibDriver`.
Sure that sounds good to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D29892





More information about the llvm-commits mailing list