[PATCH] D33155: [DWARFv5] Support FORM_strp in the line table header

[Paul Robinson via Phabricator via llvm-commits]

probinson added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:68
+/// The API follows the equivalent DWARFUnit method names.
+class DWARFFVUnit {
+  const DWARFUnit *U;
----------------
aprantl wrote:
> I found the FV a bit hard to parse... DWARFUnitProxy, maybe?
It's specific to DWARFFormValue, which is why I stuck with the FV.
But maybe that's not important, and DWARFUnitProxy would be okay.



================
Comment at: lib/DebugInfo/DWARF/DWARFFormValue.cpp:122
+  const RelocAddrMap *getRelocMap() const { return RM; }
+  DataExtractor getStringExtractor() const {
+    if (U)
----------------
aprantl wrote:
> Are these methods used anywhere? (Or will that come later?)
They are used now (e.g. in getAsCString).  The old helper class didn't need them because the old helper class was used only in getFixedByteSize() and skipFormValue().  But the new helper is used in places where it used to call the Unit methods directly, so it needs all these.


https://reviews.llvm.org/D33155