[PATCH] D31724: [SelectionDAG] Remove special call to LHS computeKnownBits for ANDs with constant RHS.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 14:22:00 PDT 2017


spatel added a comment.

In https://reviews.llvm.org/D31724#753822, @craig.topper wrote:

> Yeah I think we should. That failure only showed up when I was rebasing. Is that something I should look into?


Sure. I fixed some of the opcodes to be splat-aware a few weeks ago, but I'll take any help I can get to complete the job. :)
Beware: I think I saw a miscompile from one of those opcodes when I changed it to use 'isConstOrConstSplat'. There may be something ugly going on here. I'll see if I left any notes for myself about what went wrong.


https://reviews.llvm.org/D31724





More information about the llvm-commits mailing list