[PATCH] D32746: [globalisel][legalizer] G_LOAD/G_STORE NarrowScalar should not emit G_GEP x, 0.

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 14:15:17 PDT 2017


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM modulo a small refactoring to avoid code duplication.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:288
+      } else
+        DstReg = MI.getOperand(1).getReg();
+
----------------
Could you factorize the code in a helper function?


https://reviews.llvm.org/D32746





More information about the llvm-commits mailing list