[PATCH] D33144: [RegisterBankInfo] Remove overly-agressive asserts

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 11:59:53 PDT 2017


qcolombet requested changes to this revision.
qcolombet added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/CodeGen/GlobalISel/RegBankSelect.cpp:449
     uint64_t RepairCost = getRepairCost(MO, ValMapping);
     // Bias used for splitting: 5%.
     const uint64_t PercentageForBias = 5;
----------------
Add a check for the RepairCost here. Otherwise we are going to have overflow in the following computation.

I.e., if (RepairCost == UINT_MAX)
            continue;


https://reviews.llvm.org/D33144





More information about the llvm-commits mailing list